Fixing compatibility with older versions. #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In old versions the index out of bounds exception was called. Parts of the code from this project were used, which has a more consistent way of obtaining versions from Regex: https://github.com/lucko/helper/blob/master/helper/src/main/java/me/lucko/helper/reflect/MinecraftVersions.java#L139
GodCipher
added
bug
olijeffers0n
approved these changes
Jun 24, 2024
|
Good catch, thanks for contributing! We will consider your PR in the next update of pathetic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs a backward compatibility fix.
In older versions, the method for obtaining the server version did not work, as it threw an index out of bounds when it was obtained. This PR implements a more consistent way of obtaining the server version from the code in this project here.
Another error was with classes not supported for older java, because they were compiled with more recent versions. Specifically the PatheticMapper class as shown in the image.
Centralize all maven compatibility properties (source and target) only in the parent project to prevent child projects from having compatibility with different versions of java.
NOTE: Only tested on version 1.8.9, tests for other versions may be necessary.